From: Greg Kroah-Hartman Date: Mon, 9 Oct 2023 18:27:39 +0000 (+0200) Subject: 4.14-stable patches X-Git-Tag: v4.14.327~15 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=673d0c84192872c6670ec3110b4cf59085e6c73a;p=thirdparty%2Fkernel%2Fstable-queue.git 4.14-stable patches added patches: revert-rtnetlink-reject-negative-ifindexes-in-rtm_newlink.patch --- diff --git a/queue-4.14/revert-rtnetlink-reject-negative-ifindexes-in-rtm_newlink.patch b/queue-4.14/revert-rtnetlink-reject-negative-ifindexes-in-rtm_newlink.patch new file mode 100644 index 00000000000..65b3b6221f2 --- /dev/null +++ b/queue-4.14/revert-rtnetlink-reject-negative-ifindexes-in-rtm_newlink.patch @@ -0,0 +1,40 @@ +From 8d271d77834f96bd04ff3a29eb688d4364eec009 Mon Sep 17 00:00:00 2001 +From: Greg Kroah-Hartman +Date: Mon, 9 Oct 2023 20:25:00 +0200 +Subject: Revert "rtnetlink: Reject negative ifindexes in RTM_NEWLINK" + +From: Greg Kroah-Hartman + +This reverts commit 69197b2b2a7bcf92b209490639316af5dc751cc0 which is +commit 30188bd7838c16a98a520db1fe9df01ffc6ed368 upstream. + +It was improperly backported to 4.14.y, and applied to the wrong +function, which obviously causes problems. A fixed version will be +applied as a separate commit later. + +Reported-by: Boris Ostrovsky +Link: https://lore.kernel.org/r/ZSQeA8fhUT++iZvz@ostr-mac +Cc: Ido Schimmel +Cc: Jiri Pirko +Cc: Jakub Kicinski +Cc: Paolo Abeni +Cc: Sasha Levin +Signed-off-by: Greg Kroah-Hartman +--- + net/core/rtnetlink.c | 5 +---- + 1 file changed, 1 insertion(+), 4 deletions(-) + +--- a/net/core/rtnetlink.c ++++ b/net/core/rtnetlink.c +@@ -2311,10 +2311,7 @@ static int rtnl_setlink(struct sk_buff * + ifm = nlmsg_data(nlh); + if (ifm->ifi_index > 0) + dev = __dev_get_by_index(net, ifm->ifi_index); +- else if (ifm->ifi_index < 0) { +- NL_SET_ERR_MSG(extack, "ifindex can't be negative"); +- return -EINVAL; +- } else if (tb[IFLA_IFNAME]) ++ else if (tb[IFLA_IFNAME]) + dev = __dev_get_by_name(net, ifname); + else + goto errout; diff --git a/queue-4.14/series b/queue-4.14/series index fc8d7c9f913..adac1353bb5 100644 --- a/queue-4.14/series +++ b/queue-4.14/series @@ -53,3 +53,4 @@ gpio-aspeed-fix-the-gpio-number-passed-to-pinctrl_gpio_set_config.patch rdma-cma-fix-truncation-compilation-warning-in-make_cma_ports.patch rdma-mlx5-fix-null-string-error.patch parisc-restore-__ldcw_align-for-pa-risc-2.0-processors.patch +revert-rtnetlink-reject-negative-ifindexes-in-rtm_newlink.patch