From: Jeremy Allison <jra@samba.org>
Date: Wed, 9 Sep 2020 17:58:20 +0000 (-0700)
Subject: s3: libsmb: Cleanup - in internal_resolve_name() only write the out parameters on... 
X-Git-Tag: talloc-2.3.2~480
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=67498ffd78799a658991092186a3886204302947;p=thirdparty%2Fsamba.git

s3: libsmb: Cleanup - in internal_resolve_name() only write the out parameters on success.

All callers already correctly initialize them.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>

Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Tue Sep 15 11:33:35 UTC 2020 on sn-devel-184
---

diff --git a/source3/libsmb/namequery.c b/source3/libsmb/namequery.c
index 1c7bbfeb151..bf53e01bfb7 100644
--- a/source3/libsmb/namequery.c
+++ b/source3/libsmb/namequery.c
@@ -3175,9 +3175,6 @@ NTSTATUS internal_resolve_name(TALLOC_CTX *ctx,
 	struct samba_sockaddr *sa_list = NULL;
 	TALLOC_CTX *frame = talloc_stackframe();
 
-	*return_salist = NULL;
-	*return_count = 0;
-
 	DBG_DEBUG("looking up %s#%x (sitename %s)\n",
 		name, name_type, sitename ? sitename : "(null)");