From: Nick Mathewson <nickm@torproject.org>
Date: Fri, 17 Feb 2017 16:31:39 +0000 (-0500)
Subject: Check for micro < 0, rather than checking "minor" twice.
X-Git-Tag: tor-0.2.9.10~8^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=67cec7578cab40ce43b54d4dfc1370894b91d28f;p=thirdparty%2Ftor.git

Check for micro < 0, rather than checking "minor" twice.

Bug found with clang scan-build.  Fixes bug on f63e06d3dc6757d.
Bug not present in any released Tor.
---

diff --git a/src/or/routerparse.c b/src/or/routerparse.c
index 7d9769b499..2ee0d2720e 100644
--- a/src/or/routerparse.c
+++ b/src/or/routerparse.c
@@ -5551,7 +5551,7 @@ tor_version_parse_platform(const char *platform,
   if (strict) {
     if (router_version->major < 0 ||
         router_version->minor < 0 ||
-        router_version->minor < 0 ||
+        router_version->micro < 0 ||
         router_version->patchlevel < 0 ||
         router_version->svn_revision < 0) {
       return -1;