From: Nick Mathewson <nickm@torproject.org>
Date: Mon, 18 Jun 2018 20:17:11 +0000 (-0400)
Subject: New check-spaces rule: Our C files may not have duplicate names.
X-Git-Tag: tor-0.3.5.1-alpha~425
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=67dc83fa75e2009b4b6bd5d7f005adcaf45d0c77;p=thirdparty%2Ftor.git

New check-spaces rule: Our C files may not have duplicate names.
---

diff --git a/scripts/maint/checkSpace.pl b/scripts/maint/checkSpace.pl
index 4f4ac9b0e5..633b47e314 100755
--- a/scripts/maint/checkSpace.pl
+++ b/scripts/maint/checkSpace.pl
@@ -16,12 +16,21 @@ if ($ARGV[0] =~ /^-/) {
     $C = ($lang eq '-C');
 }
 
+our %basenames = ();
+
 for my $fn (@ARGV) {
     open(F, "$fn");
     my $lastnil = 0;
     my $lastline = "";
     my $incomment = 0;
     my $in_func_head = 0;
+    my $basename = $fn;
+    $basename =~ s#.*/##;
+    if ($basenames{$basename}) {
+        msg "Duplicate fnames: $fn and $basenames{$basename}.\n";
+    } else {
+        $basenames{$basename} = $fn;
+    }
     while (<F>) {
         ## Warn about windows-style newlines.
         #    (We insist on lines that end with a single LF character, not