From: Marcin Siodelski <marcin@isc.org>
Date: Wed, 14 Dec 2016 16:43:22 +0000 (+0100)
Subject: [5077] Removed extraneous state transitions in HTTP request parser.
X-Git-Tag: trac5088_base~5^2~9
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=67e69191f82f1b0091ea7cd2601c0c8f242ea0fc;p=thirdparty%2Fkea.git

[5077] Removed extraneous state transitions in HTTP request parser.
---

diff --git a/src/lib/http/request_parser.cc b/src/lib/http/request_parser.cc
index c76434991b..da42b300f1 100644
--- a/src/lib/http/request_parser.cc
+++ b/src/lib/http/request_parser.cc
@@ -347,7 +347,6 @@ HttpRequestParser::uriHandler() {
 
         } else if (isCtl(c)) {
             parseFailure("control character found in HTTP URI");
-            transition(HTTP_PARSE_FAILED_ST, HTTP_PARSE_FAILED_EVT);
 
         } else {
             // Still parsing the URI. Append the next character to the
@@ -397,7 +396,6 @@ HttpRequestParser::versionNumberStartHandler(const unsigned int next_state,
         } else {
             parseFailure("expected digit in HTTP version, found " +
                          std::string(1, c));
-            transition(HTTP_PARSE_FAILED_ST, HTTP_PARSE_FAILED_EVT);
         }
     });
 }
@@ -421,7 +419,6 @@ HttpRequestParser::versionNumberHandler(const char following_character,
         } else {
             parseFailure("expected digit in HTTP version, found " +
                          std::string(1, c));
-            transition(HTTP_PARSE_FAILED_ST, HTTP_PARSE_FAILED_EVT);
         }
     });
 }