From: Petr Menšík <pemensik@redhat.com>
Date: Wed, 19 Jan 2022 12:35:32 +0000 (+0100)
Subject: Ensure diff variable is not read uninitialized
X-Git-Tag: v9.19.1~30^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=67e773c93c2fe164e3791e0b843f724a6d9358d4;p=thirdparty%2Fbind9.git

Ensure diff variable is not read uninitialized

Coverity detected issues:
- var_decl: Declaring variable "diff" without initializer.
- uninit_use_in_call: Using uninitialized value "diff.tuples.head" when
  calling "dns_diff_clear".
---

diff --git a/lib/dns/zone.c b/lib/dns/zone.c
index ed3d3eda2bd..794154d8b53 100644
--- a/lib/dns/zone.c
+++ b/lib/dns/zone.c
@@ -23450,7 +23450,7 @@ setserial(isc_task_t *task, isc_event_t *event) {
 	ENTER;
 
 	if (zone->update_disabled) {
-		goto failure;
+		goto disabled;
 	}
 
 	desired = sse->serial;
@@ -23529,6 +23529,8 @@ failure:
 		dns_db_detach(&db);
 	}
 	dns_diff_clear(&diff);
+
+disabled:
 	isc_event_free(&event);
 	dns_zone_idetach(&zone);