From: George Kadianakis <desnacked@riseup.net>
Date: Tue, 8 Aug 2017 18:25:04 +0000 (+0300)
Subject: prop224: Add XXX about opaqueness of link_specifier_t.
X-Git-Tag: tor-0.3.2.1-alpha~171^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=686891d67ebf69808ac3d2b2c98263d21a3fe143;p=thirdparty%2Ftor.git

prop224: Add XXX about opaqueness of link_specifier_t.
---

diff --git a/src/trunnel/ed25519_cert.h b/src/trunnel/ed25519_cert.h
index 782bd59585..0aa953d174 100644
--- a/src/trunnel/ed25519_cert.h
+++ b/src/trunnel/ed25519_cert.h
@@ -59,6 +59,10 @@ struct link_specifier_st {
 };
 #endif
 typedef struct link_specifier_st link_specifier_t;
+/** XXX hs_link_specifier_dup() violates the opaqueness of link_specifier_t by
+ *  taking its sizeof(). If we ever want to turn on TRUNNEL_OPAQUE we would
+ *  need to refactor that function to do the coyp by encoding and decoding the
+ *  object. */
 #if !defined(TRUNNEL_OPAQUE) && !defined(TRUNNEL_OPAQUE_ED25519_CERT)
 struct ed25519_cert_st {
   uint8_t version;