From: Fred Drake <fdrake@acm.org>
Date: Fri, 8 Feb 2002 21:31:23 +0000 (+0000)
Subject: start() and stop() methods: return None where there is no exception;
X-Git-Tag: v2.2.1c1~211
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=68726f5384167f33be42984510df83a8df82e149;p=thirdparty%2FPython%2Fcpython.git

start() and stop() methods: return None where there is no exception;
returning NULL causes the interpreter to raise a SystemError.
Noted by Anthony Baxter at Python 10.
---

diff --git a/Modules/_hotshot.c b/Modules/_hotshot.c
index ebaf37c3578e..f88629dc4f32 100644
--- a/Modules/_hotshot.c
+++ b/Modules/_hotshot.c
@@ -1180,8 +1180,11 @@ profiler_start(ProfilerObject *self, PyObject *args)
     PyObject *result = NULL;
 
     if (PyArg_ParseTuple(args, ":start")) {
-        if (is_available(self))
+        if (is_available(self)) {
             do_start(self);
+            result = Py_None;
+            Py_INCREF(result);
+        }
     }
     return result;
 }
@@ -1198,8 +1201,11 @@ profiler_stop(ProfilerObject *self, PyObject *args)
     if (PyArg_ParseTuple(args, ":stop")) {
         if (!self->active)
             PyErr_SetString(ProfilerError, "profiler not active");
-        else
+        else {
             do_stop(self);
+            result = Py_None;
+            Py_INCREF(result);
+        }
     }
     return result;
 }