From: Serhiy Storchaka <storchaka@gmail.com>
Date: Mon, 29 Jul 2024 18:52:48 +0000 (+0300)
Subject: gh-122311: Fix a refleak in pickle (GH-122411)
X-Git-Tag: v3.14.0a1~946
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=68840e91ac6689d3954b98a9ab136e194b5250b8;p=thirdparty%2FPython%2Fcpython.git

gh-122311: Fix a refleak in pickle (GH-122411)
---

diff --git a/Modules/_pickle.c b/Modules/_pickle.c
index 452b4aff0237..50c73dca0db2 100644
--- a/Modules/_pickle.c
+++ b/Modules/_pickle.c
@@ -3123,6 +3123,7 @@ batch_dict(PickleState *state, PicklerObject *self, PyObject *iter)
             if (!PyTuple_Check(obj) || PyTuple_Size(obj) != 2) {
                 PyErr_SetString(PyExc_TypeError, "dict items "
                                 "iterator must return 2-tuples");
+                Py_DECREF(obj);
                 return -1;
             }
             i = save(state, self, PyTuple_GET_ITEM(obj, 0), 0);