From: Pronyushkin Petr <pyetr.pronyushkin@fsight.ru>
Date: Fri, 3 Feb 2023 06:26:30 +0000 (+0500)
Subject: url: fix part of conditional expression is always true
X-Git-Tag: curl-7_88_0~65
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=690c43b3eecd908cfea2c7451b00c84294aab1ea;p=thirdparty%2Fcurl.git

url: fix part of conditional expression is always true

Closes #10407
---

diff --git a/lib/url.c b/lib/url.c
index 3f9142e812..e8f2d12b89 100644
--- a/lib/url.c
+++ b/lib/url.c
@@ -2744,7 +2744,7 @@ static CURLcode override_login(struct Curl_easy *data,
         return CURLE_OUT_OF_MEMORY;
     }
     /* no user was set but a password, set a blank user */
-    if(userp && !*userp && *passwdp) {
+    if(!*userp && *passwdp) {
       *userp = strdup("");
       if(!*userp)
         return CURLE_OUT_OF_MEMORY;