From: Timo Sirainen <tss@iki.fi>
Date: Tue, 14 Sep 2010 13:45:01 +0000 (+0100)
Subject: lib-settings: Give a better error message for invalid boolean values
X-Git-Tag: 2.0.3~20
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=691b39f8bac105c73c5982c456d378b3b2ee7a07;p=thirdparty%2Fdovecot%2Fcore.git

lib-settings: Give a better error message for invalid boolean values
---

diff --git a/src/lib-settings/settings-parser.c b/src/lib-settings/settings-parser.c
index 5f43a219fd..55f0359857 100644
--- a/src/lib-settings/settings-parser.c
+++ b/src/lib-settings/settings-parser.c
@@ -298,8 +298,8 @@ get_bool(struct setting_parser_context *ctx, const char *value, bool *result_r)
 	else if (strcasecmp(value, "no") == 0)
 		*result_r = FALSE;
 	else {
-		ctx->error = p_strconcat(ctx->parser_pool, "Invalid boolean: ",
-					 value, NULL);
+		ctx->error = p_strdup_printf(ctx->parser_pool,
+			"Invalid boolean value: %s (use yes or no)", value);
 		return -1;
 	}