From: Raymond Hettinger <python@rcn.com>
Date: Sat, 21 Mar 2015 09:03:40 +0000 (-0700)
Subject: Minor nit.  Make the rotate() success/fail tests consistent.
X-Git-Tag: v3.5.0a3~95
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6921c13bbbb2c9695edd87331d98f7aa1e48f7f2;p=thirdparty%2FPython%2Fcpython.git

Minor nit.  Make the rotate() success/fail tests consistent.
---

diff --git a/Modules/_collectionsmodule.c b/Modules/_collectionsmodule.c
index 28aacc3317c6..b8316279ac5e 100644
--- a/Modules/_collectionsmodule.c
+++ b/Modules/_collectionsmodule.c
@@ -634,7 +634,7 @@ deque_rotate(dequeobject *deque, PyObject *args)
 
     if (!PyArg_ParseTuple(args, "|n:rotate", &n))
         return NULL;
-    if (_deque_rotate(deque, n) == 0)
+    if (!_deque_rotate(deque, n))
         Py_RETURN_NONE;
     return NULL;
 }
@@ -864,7 +864,7 @@ deque_remove(dequeobject *deque, PyObject *value)
         if (cmp > 0) {
             PyObject *tgt = deque_popleft(deque, NULL);
             assert (tgt != NULL);
-            if (_deque_rotate(deque, i) == -1)
+            if (_deque_rotate(deque, i))
                 return NULL;
             Py_DECREF(tgt);
             Py_RETURN_NONE;
@@ -959,7 +959,7 @@ deque_del_item(dequeobject *deque, Py_ssize_t i)
     int rv;
 
     assert (i >= 0 && i < Py_SIZE(deque));
-    if (_deque_rotate(deque, -i) == -1)
+    if (_deque_rotate(deque, -i))
         return -1;
     item = deque_popleft(deque, NULL);
     rv = _deque_rotate(deque, i);