From: Jouni Malinen <jouni@qca.qualcomm.com>
Date: Thu, 4 Aug 2011 19:39:03 +0000 (+0300)
Subject: TLS: Reorder certificates if needed when reading them
X-Git-Tag: hostap-1-bp~279
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6921f1f3860e8e3c1a6148b586a5b5bb406b6656;p=thirdparty%2Fhostap.git

TLS: Reorder certificates if needed when reading them

The internal TLS implementation assumes that the certificate chain
is ordered by issuer certificate following the certificate that it
signed. Add the certificates to the chain in suitable order when
loading multiple certificates.
---

diff --git a/src/tls/tlsv1_cred.c b/src/tls/tlsv1_cred.c
index aa467efc8..3e07245ec 100644
--- a/src/tls/tlsv1_cred.c
+++ b/src/tls/tlsv1_cred.c
@@ -46,7 +46,7 @@ void tlsv1_cred_free(struct tlsv1_credentials *cred)
 static int tlsv1_add_cert_der(struct x509_certificate **chain,
 			      const u8 *buf, size_t len)
 {
-	struct x509_certificate *cert;
+	struct x509_certificate *cert, *p;
 	char name[128];
 
 	cert = x509_certificate_parse(buf, len);
@@ -56,8 +56,20 @@ static int tlsv1_add_cert_der(struct x509_certificate **chain,
 		return -1;
 	}
 
-	cert->next = *chain;
-	*chain = cert;
+	p = *chain;
+	while (p && p->next)
+		p = p->next;
+	if (p && x509_name_compare(&cert->subject, &p->issuer) == 0) {
+		/*
+		 * The new certificate is the issuer of the last certificate in
+		 * the chain - add the new certificate to the end.
+		 */
+		p->next = cert;
+	} else {
+		/* Add to the beginning of the chain */
+		cert->next = *chain;
+		*chain = cert;
+	}
 
 	x509_name_string(&cert->subject, name, sizeof(name));
 	wpa_printf(MSG_DEBUG, "TLSv1: Added certificate: %s", name);