From: Petr Špaček <pspacek@isc.org>
Date: Mon, 19 Sep 2022 07:07:51 +0000 (+0200)
Subject: Fix memory leak in dns_message_checksig() - SIG(0) sigs
X-Git-Tag: v9.19.6~39^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=69256b3553d3b8b73b6fa4de9b030b39f1b96d34;p=thirdparty%2Fbind9.git

Fix memory leak in dns_message_checksig() - SIG(0) sigs

Impact should be visible only in tests or tools because named never
uses view == NULL, which is a necessary condition to trigger this leak.
---

diff --git a/lib/dns/message.c b/lib/dns/message.c
index 830d452a10e..0995821fb68 100644
--- a/lib/dns/message.c
+++ b/lib/dns/message.c
@@ -3174,7 +3174,8 @@ dns_message_checksig(dns_message_t *msg, dns_view_t *view) {
 
 		dns_rdataset_init(&keyset);
 		if (view == NULL) {
-			return (DNS_R_KEYUNAUTHORIZED);
+			result = DNS_R_KEYUNAUTHORIZED;
+			goto freesig;
 		}
 		result = dns_view_simplefind(view, &sig.signer,
 					     dns_rdatatype_key /* SIG(0) */, 0,