From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 21 Feb 2017 18:46:37 +0000 (+0300)
Subject: scsi: scsi_dh_emc: return success in clariion_std_inquiry()
X-Git-Tag: v4.4.94~10
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=693e6513b2449085f53659f5761eeb450720e9e4;p=thirdparty%2Fkernel%2Fstable.git

scsi: scsi_dh_emc: return success in clariion_std_inquiry()


[ Upstream commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b ]

We accidentally return an uninitialized variable on success.

Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/scsi/device_handler/scsi_dh_emc.c b/drivers/scsi/device_handler/scsi_dh_emc.c
index e6fb97cb12f43..7c28dc1cb0dd3 100644
--- a/drivers/scsi/device_handler/scsi_dh_emc.c
+++ b/drivers/scsi/device_handler/scsi_dh_emc.c
@@ -456,7 +456,7 @@ static int clariion_prep_fn(struct scsi_device *sdev, struct request *req)
 static int clariion_std_inquiry(struct scsi_device *sdev,
 				struct clariion_dh_data *csdev)
 {
-	int err;
+	int err = SCSI_DH_OK;
 	char *sp_model;
 
 	err = send_inquiry_cmd(sdev, 0, csdev);