From: Antoine Pitrou <solipsis@pitrou.net>
Date: Sun, 16 Dec 2012 15:09:11 +0000 (+0100)
Subject: Fix ResourceWarnings in test_pty
X-Git-Tag: v3.2.4rc1~263
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=697ce5560fec5bb3207f3d975e34dc6a702016ec;p=thirdparty%2FPython%2Fcpython.git

Fix ResourceWarnings in test_pty
---

diff --git a/Lib/test/test_pty.py b/Lib/test/test_pty.py
index 4f1251cd3683..fcebce78e85d 100644
--- a/Lib/test/test_pty.py
+++ b/Lib/test/test_pty.py
@@ -215,7 +215,7 @@ class SmallPtyTests(unittest.TestCase):
         for fd in self.fds:
             try:
                 os.close(fd)
-            except:
+            except OSError:
                 pass
 
     def _pipe(self):
@@ -235,8 +235,9 @@ class SmallPtyTests(unittest.TestCase):
         mock_stdin_fd, write_to_stdin_fd = self._pipe()
         pty.STDIN_FILENO = mock_stdin_fd
         socketpair = socket.socketpair()
+        for s in socketpair:
+            self.addCleanup(s.close)
         masters = [s.fileno() for s in socketpair]
-        self.fds.extend(masters)
 
         # Feed data.  Smaller than PIPEBUF.  These writes will not block.
         os.write(masters[1], b'from master')
@@ -264,8 +265,9 @@ class SmallPtyTests(unittest.TestCase):
         mock_stdin_fd, write_to_stdin_fd = self._pipe()
         pty.STDIN_FILENO = mock_stdin_fd
         socketpair = socket.socketpair()
+        for s in socketpair:
+            self.addCleanup(s.close)
         masters = [s.fileno() for s in socketpair]
-        self.fds.extend(masters)
 
         os.close(masters[1])
         socketpair[1].close()