From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Mon, 3 Feb 2025 23:24:56 +0000 (+0100)
Subject: [3.12] gh-129345: null check for indent syslogmodule (GH-129348) (#129443)
X-Git-Tag: v3.12.9~6
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6985b4be9b01f3c6d581a93e58f5b14adb793d92;p=thirdparty%2FPython%2Fcpython.git

[3.12] gh-129345: null check for indent syslogmodule (GH-129348) (#129443)

gh-129345: null check for indent syslogmodule (GH-129348)
(cherry picked from commit 25cf79a0829422bd8479ca0c13c72b769422077b)

Co-authored-by: Burkov Egor <xwooffie@gmail.com>
---

diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst b/Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst
new file mode 100644
index 000000000000..68e1103db456
--- /dev/null
+++ b/Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst
@@ -0,0 +1 @@
+Fix null pointer dereference in :func:`syslog.openlog` when an audit hook raises an exception.
diff --git a/Modules/syslogmodule.c b/Modules/syslogmodule.c
index 722364e0751d..c925a42dc05c 100644
--- a/Modules/syslogmodule.c
+++ b/Modules/syslogmodule.c
@@ -170,7 +170,7 @@ syslog_openlog_impl(PyObject *module, PyObject *ident, long logopt,
         }
     }
     if (PySys_Audit("syslog.openlog", "Oll", ident ? ident : Py_None, logopt, facility) < 0) {
-        Py_DECREF(ident);
+        Py_XDECREF(ident);
         return NULL;
     }