From: Mike Yuan <me@yhndnzj.com>
Date: Sat, 12 Apr 2025 17:13:35 +0000 (+0200)
Subject: stdio-bridge: minor modernization for parse_argv()
X-Git-Tag: v258-rc1~833^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6989688a51a2f5879091da401f6c94e9bcecac8d;p=thirdparty%2Fsystemd.git

stdio-bridge: minor modernization for parse_argv()
---

diff --git a/src/stdio-bridge/stdio-bridge.c b/src/stdio-bridge/stdio-bridge.c
index f48b7e574e3..71326789cbb 100644
--- a/src/stdio-bridge/stdio-bridge.c
+++ b/src/stdio-bridge/stdio-bridge.c
@@ -92,10 +92,14 @@ static int parse_argv(int argc, char *argv[]) {
                         return -EINVAL;
 
                 default:
-                        return log_error_errno(SYNTHETIC_ERRNO(EINVAL),
-                                               "Unknown option code %c", c);
+                        assert_not_reached();
                 }
 
+        if (argc > optind)
+                return log_error_errno(SYNTHETIC_ERRNO(EINVAL),
+                                       "%s takes no arguments.",
+                                       program_invocation_short_name);
+
         return 1;
 }