From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Sun, 22 Mar 2026 11:55:13 +0000 (+0100)
Subject: [3.14] gh-146245: Fix reference and buffer leaks via audit hook in socket module... 
X-Git-Tag: v3.14.4~93
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=69a37be21c56d26aa616e64069bfe45c63ebb04e;p=thirdparty%2FPython%2Fcpython.git

[3.14] gh-146245: Fix reference and buffer leaks via audit hook in socket module (GH-146248) (GH-146274)

(cherry picked from commit c30fae4bea9f9ba07833e97eb542754c26610765)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
---

diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2026-03-21-08-48-25.gh-issue-146245.cqM3_4.rst b/Misc/NEWS.d/next/Core_and_Builtins/2026-03-21-08-48-25.gh-issue-146245.cqM3_4.rst
new file mode 100644
index 000000000000..f52eaa0d6c72
--- /dev/null
+++ b/Misc/NEWS.d/next/Core_and_Builtins/2026-03-21-08-48-25.gh-issue-146245.cqM3_4.rst
@@ -0,0 +1 @@
+Fixed reference leaks in :mod:`socket` when audit hooks raise exceptions in :func:`socket.getaddrinfo` and :meth:`!socket.sendto`.
diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c
index 563a930bbcd7..c415c93ccb8c 100644
--- a/Modules/socketmodule.c
+++ b/Modules/socketmodule.c
@@ -4795,6 +4795,7 @@ sock_sendto(PyObject *self, PyObject *args)
     }
 
     if (PySys_Audit("socket.sendto", "OO", s, addro) < 0) {
+        PyBuffer_Release(&pbuf);
         return NULL;
     }
 
@@ -6965,7 +6966,7 @@ socket_getaddrinfo(PyObject *self, PyObject *args, PyObject* kwargs)
 
     if (PySys_Audit("socket.getaddrinfo", "OOiii",
                     hobj, pobj, family, socktype, protocol) < 0) {
-        return NULL;
+        goto err;
     }
 
     memset(&hints, 0, sizeof(hints));