From: Nick Mathewson <nickm@torproject.org>
Date: Sat, 19 Apr 2014 00:33:21 +0000 (-0400)
Subject: scan-build: fix a crash-on-fail possibility in test_policy.c
X-Git-Tag: tor-0.2.5.4-alpha~14^2~14
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=69ea4450caee65be56912fd2618c2b95413a0763;p=thirdparty%2Ftor.git

scan-build: fix a crash-on-fail possibility in test_policy.c
---

diff --git a/src/test/test_policy.c b/src/test/test_policy.c
index d2ba1612de..491c9a21fb 100644
--- a/src/test/test_policy.c
+++ b/src/test/test_policy.c
@@ -417,8 +417,10 @@ test_dump_exit_policy_to_string(void *arg)
 
  done:
 
- SMARTLIST_FOREACH(ri->exit_policy, addr_policy_t *,
-                   entry, addr_policy_free(entry));
+ if (ri->exit_policy) {
+   SMARTLIST_FOREACH(ri->exit_policy, addr_policy_t *,
+                     entry, addr_policy_free(entry));
+ }
  tor_free(ri);
  tor_free(ep);
 }