From: Theodore Ts'o <tytso@mit.edu>
Date: Wed, 8 Mar 2006 23:22:06 +0000 (-0500)
Subject: Fix debugfs's icheck to correctly report the owner of an EA block
X-Git-Tag: E2FSPROGS-1.39-WIP-0330~38
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6a2efe047d19d86d1a78f7fc4ff1bf256437c267;p=thirdparty%2Fe2fsprogs.git

Fix debugfs's icheck to correctly report the owner of an EA block

Hello Ted,
here is a minor fixup with debugfs "icheck" finding a block in an EA.
It was reporting the inode number as one too low because it was set
after the EA check is done.

From: Andreas Dilger <adilger@clusterfs.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---

diff --git a/debugfs/ChangeLog b/debugfs/ChangeLog
index 3d7193d09..f5bc00129 100644
--- a/debugfs/ChangeLog
+++ b/debugfs/ChangeLog
@@ -1,3 +1,8 @@
+2006-03-08  Theodore Ts'o  <tytso@mit.edu>
+
+	* Fix bug in icheck which incorrectly reports the last valid inode
+		number as the owner for an EA block.
+
 2005-12-10  Theodore Ts'o  <tytso@mit.edu>
 
 	* debugfs.c, debugfs.h, logdump.c, ls.c: Clean up various gcc
diff --git a/debugfs/icheck.c b/debugfs/icheck.c
index 6c4b0a111..e3646def4 100644
--- a/debugfs/icheck.c
+++ b/debugfs/icheck.c
@@ -109,6 +109,8 @@ void do_icheck(int argc, char **argv)
 		if (!inode.i_links_count)
 			goto next;
 
+		bw.inode = ino;
+
 		if (inode.i_file_acl) {
 			icheck_proc(current_fs, &inode.i_file_acl, 0,
 				    0, 0, &bw);
@@ -125,8 +127,6 @@ void do_icheck(int argc, char **argv)
 		if (inode.i_dtime)
 			goto next;
 
-		bw.inode = ino;
-
 		retval = ext2fs_block_iterate2(current_fs, ino, 0, block_buf,
 					       icheck_proc, &bw);
 		if (retval) {