From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Wed, 19 Mar 2025 01:35:17 +0000 (+0900)
Subject: bus-unit-procs: add one more assertion for Coverity
X-Git-Tag: v258-rc1~1042^2~7
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6a6cc56125667fe7cb8b9ceeff1a4d21fe3a3c89;p=thirdparty%2Fsystemd.git

bus-unit-procs: add one more assertion for Coverity

Hopefully fixes CID#1562447.
---

diff --git a/src/shared/bus-unit-procs.c b/src/shared/bus-unit-procs.c
index ff4852150be..19139403b80 100644
--- a/src/shared/bus-unit-procs.c
+++ b/src/shared/bus-unit-procs.c
@@ -153,23 +153,22 @@ static int dump_processes(
 
         if (!hashmap_isempty(cg->pids)) {
                 const char *name;
-                size_t n = 0, i;
-                pid_t *pids;
                 void *pidp;
-                int width;
+                size_t n = 0;
 
                 /* Order processes by their PID */
-                pids = newa(pid_t, hashmap_size(cg->pids));
+                pid_t *pids = newa(pid_t, hashmap_size(cg->pids));
 
                 HASHMAP_FOREACH_KEY(name, pidp, cg->pids)
                         pids[n++] = PTR_TO_PID(pidp);
 
                 assert(n == hashmap_size(cg->pids));
+                assert(n > 0);
                 typesafe_qsort(pids, n, pid_compare_func);
 
-                width = DECIMAL_STR_WIDTH(pids[n-1]);
+                int width = DECIMAL_STR_WIDTH(pids[n-1]);
 
-                for (i = 0; i < n; i++) {
+                for (size_t i = 0; i < n; i++) {
                         _cleanup_free_ char *e = NULL;
                         const char *special;
                         bool more;