From: Kevin P. Fleming <kpfleming@digium.com>
Date: Thu, 5 Oct 2006 16:10:01 +0000 (+0000)
Subject: don't segfault when an argument without a close parenthesis is found
X-Git-Tag: 1.4.0-beta3~76
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6a70807a3673140fb3dda37001bcd857975d6867;p=thirdparty%2Fasterisk.git

don't segfault when an argument without a close parenthesis is found
stop parsing as soon as that situation occurs


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44476 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/main/app.c b/main/app.c
index b6a7f73a9a..e640a762e1 100644
--- a/main/app.c
+++ b/main/app.c
@@ -1302,14 +1302,14 @@ int ast_app_parse_options(const struct ast_app_option *options, struct ast_flags
 		if (*s == '(') {
 			/* Has argument */
 			arg = ++s;
-			s = strchr(s, ')');
-			if (*s) {
+			if ((s = strchr(s, ')'))) {
 				if (argloc)
 					args[argloc - 1] = arg;
 				*s++ = '\0';
 			} else {
 				ast_log(LOG_WARNING, "Missing closing parenthesis for argument '%c' in string '%s'\n", curarg, arg);
 				res = -1;
+				break;
 			}
 		} else if (argloc) {
 			args[argloc - 1] = NULL;