From: Volker Lendecke <vl@samba.org>
Date: Tue, 10 Apr 2018 19:13:37 +0000 (+0200)
Subject: winbind: Fix CID 1427625 Calling risky function
X-Git-Tag: ldb-1.4.0~651
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6a9bc0fa209798c8e4d88a68dcc6ad0b95925a52;p=thirdparty%2Fsamba.git

winbind: Fix CID 1427625 Calling risky function

Probably not really a problem, but we have generate_random(), so why not
use it?

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/winbindd/winbindd_gpupdate.c b/source3/winbindd/winbindd_gpupdate.c
index 48ebb5501aa..c86c007be12 100644
--- a/source3/winbindd/winbindd_gpupdate.c
+++ b/source3/winbindd/winbindd_gpupdate.c
@@ -34,7 +34,7 @@
 #define GPUPDATE_RAND_OFFSET    (30*60)
 static uint32_t gpupdate_interval(void)
 {
-	int rand_int_offset = rand() % GPUPDATE_RAND_OFFSET;
+	int rand_int_offset = generate_random() % GPUPDATE_RAND_OFFSET;
 	return GPUPDATE_INTERVAL+rand_int_offset;
 }