From: Lennart Poettering Date: Tue, 14 Jul 2026 12:42:49 +0000 (+0200) Subject: string-util: do not accept ',' in version strings X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6acae8d17db36889237f78b9a9fcceb3ec68d9cf;p=thirdparty%2Fsystemd.git string-util: do not accept ',' in version strings Allowing this apparently has been cargo-culted from my initial sysupdate PR, but Claude and me could not find a single other software package that uses "," as a character within version strings. Hence, let's remove this, even though this is a compat breakage of a kind, in the hope nobody notices. We can easily restore this if this later shows to be an issue for people. --- diff --git a/src/basic/string-util.c b/src/basic/string-util.c index 1dc90d538ad..3d3114612c3 100644 --- a/src/basic/string-util.c +++ b/src/basic/string-util.c @@ -1469,8 +1469,8 @@ bool version_is_valid(const char *s) { if (!filename_part_is_valid(s)) return false; - /* This is a superset of the characters used by semver. We additionally allow "," and "_". */ - if (!in_charset(s, ALPHANUMERICAL ".,_-+")) + /* This is a superset of the characters used by semver. We additionally allow "_". */ + if (!in_charset(s, ALPHANUMERICAL "._-+")) return false; return true;