From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Mon, 7 Apr 2025 12:23:02 +0000 (+0200)
Subject: [3.13] gh-132171: Fix `_interpreters.run_string` crash on string subclass (GH-132173... 
X-Git-Tag: v3.13.3~19
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6afab81f72cae75baee877271a7a75c4ad187f84;p=thirdparty%2FPython%2Fcpython.git

[3.13] gh-132171: Fix `_interpreters.run_string` crash on string subclass (GH-132173) (#132219)

gh-132171: Fix `_interpreters.run_string` crash on string subclass (GH-132173)
(cherry picked from commit 398071871066548954f4c51e8250d13b7c9659e0)

Co-authored-by: sobolevn <mail@sobolevn.me>
---

diff --git a/Lib/test/test__interpreters.py b/Lib/test/test__interpreters.py
index 8f32a446572d..3de774ae8b01 100644
--- a/Lib/test/test__interpreters.py
+++ b/Lib/test/test__interpreters.py
@@ -745,6 +745,12 @@ class RunStringTests(TestBase):
         with self.assertRaises(TypeError):
             _interpreters.run_string(self.id, b'print("spam")')
 
+    def test_str_subclass_string(self):
+        class StrSubclass(str): pass
+
+        output = _run_output(self.id, StrSubclass('print(1 + 2)'))
+        self.assertEqual(output, '3\n')
+
     def test_with_shared(self):
         r, w = os.pipe()
 
diff --git a/Misc/NEWS.d/next/Library/2025-04-06-23-09-21.gh-issue-132171.zZqvfn.rst b/Misc/NEWS.d/next/Library/2025-04-06-23-09-21.gh-issue-132171.zZqvfn.rst
new file mode 100644
index 000000000000..89f34fa3168c
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2025-04-06-23-09-21.gh-issue-132171.zZqvfn.rst
@@ -0,0 +1 @@
+Fix crash of ``_interpreters.run_string`` on string subclasses.
diff --git a/Modules/_interpretersmodule.c b/Modules/_interpretersmodule.c
index c968b33939c4..8f912d803ba5 100644
--- a/Modules/_interpretersmodule.c
+++ b/Modules/_interpretersmodule.c
@@ -331,7 +331,7 @@ get_code_str(PyObject *arg, Py_ssize_t *len_p, PyObject **bytes_p, int *flags_p)
     int flags = 0;
 
     if (PyUnicode_Check(arg)) {
-        assert(PyUnicode_CheckExact(arg)
+        assert(PyUnicode_Check(arg)
                && (check_code_str((PyUnicodeObject *)arg) == NULL));
         codestr = PyUnicode_AsUTF8AndSize(arg, &len);
         if (codestr == NULL) {