From: Joseph Sutton Date: Thu, 2 Nov 2023 23:00:15 +0000 (+1300) Subject: tests/krb5: Remove unused parameter ‘expected_device_groups’ X-Git-Tag: talloc-2.4.2~821 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6b2de4748889a0b5674758169439cb7fb2106e7d;p=thirdparty%2Fsamba.git tests/krb5: Remove unused parameter ‘expected_device_groups’ It was never passed in by any callers. Signed-off-by: Joseph Sutton Reviewed-by: Andrew Bartlett --- diff --git a/python/samba/tests/krb5/conditional_ace_tests.py b/python/samba/tests/krb5/conditional_ace_tests.py index d827943382a..8d7f8b768a0 100755 --- a/python/samba/tests/krb5/conditional_ace_tests.py +++ b/python/samba/tests/krb5/conditional_ace_tests.py @@ -3165,7 +3165,6 @@ class ConditionalAceTests(ConditionalAceBaseTests): device_sids=None, device_claims=None, expected_groups=None, - expected_device_groups=None, expected_claims=None): try: code, crashes_windows = code @@ -3179,7 +3178,6 @@ class ConditionalAceTests(ConditionalAceBaseTests): self.assertIsNone(device_from_rodc) self.assertIsNone(device_sids) self.assertIsNone(device_claims) - self.assertIsNone(expected_device_groups) if client_from_rodc is None: client_from_rodc = False @@ -3274,7 +3272,6 @@ class ConditionalAceTests(ConditionalAceBaseTests): domain_sid_str = samdb.get_domain_sid() expected_groups = self.map_sids(expected_groups, None, domain_sid_str) - expected_device_groups = self.map_sids(expected_device_groups, None, domain_sid_str) # Show that obtaining a service ticket is allowed. self._tgs_req(client_tgt, code, client_creds, target_creds, @@ -3284,9 +3281,6 @@ class ConditionalAceTests(ConditionalAceBaseTests): decryption_key=target_decryption_key, expected_sid=client_sid, expected_groups=expected_groups, - expect_device_info=bool(expected_device_groups) or None, - expected_device_domain_sid=domain_sid_str, - expected_device_groups=expected_device_groups, expect_client_claims=bool(expected_claims) or None, expected_client_claims=expected_claims, expected_supported_etypes=target_etypes,