From: Marcin Siodelski <marcin@isc.org>
Date: Fri, 19 Jul 2013 11:14:02 +0000 (+0200)
Subject: [1555] Minor: added a todo comment.
X-Git-Tag: bind10-1.2.0beta1-release~335^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6b65ea8a618d32efcdc0697cf0acc534b6f13404;p=thirdparty%2Fkea.git

[1555] Minor: added a todo comment.
---

diff --git a/src/bin/dhcp4/dhcp4_srv.cc b/src/bin/dhcp4/dhcp4_srv.cc
index bc5a4d6371..a9f0a5099e 100644
--- a/src/bin/dhcp4/dhcp4_srv.cc
+++ b/src/bin/dhcp4/dhcp4_srv.cc
@@ -852,6 +852,8 @@ Dhcpv4Srv::openActiveSockets(const uint16_t port,
     }
     // Let's reopen active sockets. openSockets4 will check internally whether
     // sockets are marked active or inactive.
+    // @todo Optimization: we should not reopen all sockets but rather select
+    // those that have been affected by the new configuration.
     if (!IfaceMgr::instance().openSockets4(port, use_bcast)) {
         LOG_WARN(dhcp4_logger, DHCP4_NO_SOCKETS_OPEN);
     }
diff --git a/src/bin/dhcp6/dhcp6_srv.cc b/src/bin/dhcp6/dhcp6_srv.cc
index 30eff1e2fb..f6991ec34f 100644
--- a/src/bin/dhcp6/dhcp6_srv.cc
+++ b/src/bin/dhcp6/dhcp6_srv.cc
@@ -1133,6 +1133,8 @@ Dhcpv6Srv::openActiveSockets(const uint16_t port) {
     }
     // Let's reopen active sockets. openSockets6 will check internally whether
     // sockets are marked active or inactive.
+    // @todo Optimization: we should not reopen all sockets but rather select
+    // those that have been affected by the new configuration.
     if (!IfaceMgr::instance().openSockets6(port)) {
         LOG_WARN(dhcp6_logger, DHCP6_NO_SOCKETS_OPEN);
     }