From: Mark Andrews <marka@isc.org>
Date: Wed, 3 Nov 2021 09:10:34 +0000 (+1100)
Subject: Silence Coverity false positive
X-Git-Tag: v9.17.20~7^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6b6c89b3ea1100645bf026844546014e0b754cf7;p=thirdparty%2Fbind9.git

Silence Coverity false positive

Coverity if failing to determine that 'priv.elements[i].length' is
actually valid when 'buf[i]' is non-NULL.  Initialise 'priv' to
zeros.
---

diff --git a/lib/dns/opensslrsa_link.c b/lib/dns/opensslrsa_link.c
index 2edf0c98c38..34a882a3ef3 100644
--- a/lib/dns/opensslrsa_link.c
+++ b/lib/dns/opensslrsa_link.c
@@ -790,7 +790,7 @@ err:
 static isc_result_t
 opensslrsa_tofile(const dst_key_t *key, const char *directory) {
 	isc_result_t ret;
-	dst_private_t priv;
+	dst_private_t priv = { 0 };
 	unsigned char *bufs[8] = { NULL };
 	unsigned short i = 0;
 	EVP_PKEY *pkey;
@@ -810,7 +810,6 @@ opensslrsa_tofile(const dst_key_t *key, const char *directory) {
 	}
 
 	if (key->external) {
-		priv.nelements = 0;
 		return (dst__privstruct_writefile(key, &priv, directory));
 	}