From: Zbigniew Jędrzejewski-Szmek Date: Wed, 20 May 2020 16:10:58 +0000 (+0200) Subject: tree-wide: fix bad errno checks X-Git-Tag: v246-rc1~319^2 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6b8664cb5b2577521e2d364153eb66649e558efb;p=thirdparty%2Fsystemd.git tree-wide: fix bad errno checks --- diff --git a/src/basic/fileio.c b/src/basic/fileio.c index 34ee939526f..6b84d146243 100644 --- a/src/basic/fileio.c +++ b/src/basic/fileio.c @@ -419,7 +419,7 @@ int read_full_virtual_file(const char *filename, char **ret_contents, size_t *re break; } - if (errno != -EINTR) + if (errno != EINTR) return -errno; } diff --git a/src/boot/bootctl.c b/src/boot/bootctl.c index 222b382d572..a197668ce96 100644 --- a/src/boot/bootctl.c +++ b/src/boot/bootctl.c @@ -517,7 +517,7 @@ static int copy_file_with_version_check(const char *from, const char *to, bool f if (!force) { fd_to = open(to, O_RDONLY|O_CLOEXEC|O_NOCTTY); if (fd_to < 0) { - if (errno != -ENOENT) + if (errno != ENOENT) return log_error_errno(errno, "Failed to open \"%s\" for reading: %m", to); } else { r = version_check(fd_from, from, fd_to, to); diff --git a/src/home/homework.c b/src/home/homework.c index 71e7cfdb499..76fd79fc2a0 100644 --- a/src/home/homework.c +++ b/src/home/homework.c @@ -1051,7 +1051,7 @@ static int home_remove(UserRecord *h) { assert(ip); if (stat(ip, &st) < 0) { - if (errno != -ENOENT) + if (errno != ENOENT) return log_error_errno(errno, "Failed to stat() %s: %m", ip); } else {