From: John Hubbard Date: Sat, 4 Apr 2026 21:28:29 +0000 (-0700) Subject: gpu: nova-core: vbios: use from_le_bytes() for PCI ROM header parsing X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6b9a10d6f0a131a8ea6beae559a31084840b063d;p=thirdparty%2Fkernel%2Flinux.git gpu: nova-core: vbios: use from_le_bytes() for PCI ROM header parsing Clippy fires two clippy::precedence warnings on the manual byte-shifting expression: warning: operator precedence can trip the unwary --> drivers/gpu/nova-core/vbios.rs:511:17 | 511 | / u32::from(data[29]) << 24 512 | | | u32::from(data[28]) << 16 513 | | | u32::from(data[27]) << 8 | |______________________________________________^ Clear the warnings by replacing manual byte-shifting with u32::from_le_bytes(). Using from_le_bytes() is also a tiny code improvement, because it uses less code and is clearer about the intent. Signed-off-by: John Hubbard Link: https://patch.msgid.link/20260404212831.78971-2-jhubbard@nvidia.com Signed-off-by: Danilo Krummrich --- diff --git a/drivers/gpu/nova-core/vbios.rs b/drivers/gpu/nova-core/vbios.rs index 3e3fa5b72524a..ebda28e596c5f 100644 --- a/drivers/gpu/nova-core/vbios.rs +++ b/drivers/gpu/nova-core/vbios.rs @@ -507,12 +507,7 @@ impl PciRomHeader { if data.len() >= 30 { // Read size_of_block at offset 0x1A. - size_of_block = Some( - u32::from(data[29]) << 24 - | u32::from(data[28]) << 16 - | u32::from(data[27]) << 8 - | u32::from(data[26]), - ); + size_of_block = Some(u32::from_le_bytes([data[26], data[27], data[28], data[29]])); } // For NBSI images, try to read the nbsiDataOffset at offset 0x16.