From: Jeremy Allison <jra@samba.org>
Date: Wed, 26 Aug 2020 22:20:22 +0000 (-0700)
Subject: s3: libsmb: Cleanup - Use helper variable for return from namecache_fetch() in intern... 
X-Git-Tag: talloc-2.3.2~630
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6bee431be3ce005b5ae547ffb50e4bdfb5aca902;p=thirdparty%2Fsamba.git

s3: libsmb: Cleanup - Use helper variable for return from namecache_fetch() in internal_resolve_name().

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
---

diff --git a/source3/libsmb/namequery.c b/source3/libsmb/namequery.c
index 7c33f0e6142..2a91ec4e98d 100644
--- a/source3/libsmb/namequery.c
+++ b/source3/libsmb/namequery.c
@@ -3203,7 +3203,8 @@ NTSTATUS internal_resolve_name(const char *name,
 
 	/* Check name cache */
 
-	if (namecache_fetch(name, name_type, return_iplist, return_count)) {
+	ok = namecache_fetch(name, name_type, return_iplist, return_count);
+	if (ok) {
 		*return_count = remove_duplicate_addrs2(*return_iplist,
 					*return_count );
 		/* This could be a negative response */