From: Andreas Schneider <asn@samba.org>
Date: Fri, 10 Jun 2022 11:22:00 +0000 (+0200)
Subject: s4:selftest: Fix shellcheck errors in wintest_2k3_dc.sh
X-Git-Tag: talloc-2.4.0~1365
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6c2871429f8cfc7b480fcae9e944d75709ff74ee;p=thirdparty%2Fsamba.git

s4:selftest: Fix shellcheck errors in wintest_2k3_dc.sh

source4/selftest/win/wintest_2k3_dc.sh:57:16: error: Use braces when
expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet). [SC1087]

source4/selftest/win/wintest_2k3_dc.sh:62:16: error: Use braces when
expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet). [SC1087]

source4/selftest/win/wintest_2k3_dc.sh:85:16: error: Use braces when
expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet). [SC1087]

source4/selftest/win/wintest_2k3_dc.sh:101:16: error: Use braces when
expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet). [SC1087]

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
---

diff --git a/source4/selftest/win/wintest_2k3_dc.sh b/source4/selftest/win/wintest_2k3_dc.sh
index 4852e22a01c..e77c2e22229 100755
--- a/source4/selftest/win/wintest_2k3_dc.sh
+++ b/source4/selftest/win/wintest_2k3_dc.sh
@@ -54,12 +54,12 @@ drsuapi_tests()
 
 	name="RPC-DRSUAPI on ncacn_ip_tcp with seal"
 	bin/smbtorture \
-		ncacn_ip_tcp:$server[seal] $OPTIONS \
+		ncacn_ip_tcp:${server}[seal] $OPTIONS \
 		RPC-DRSUAPI || on_error "$name"
 
 	name="RPC-DRSUAPI on ncacn_ip_tcp with seal,bigendian"
 	bin/smbtorture \
-		ncacn_ip_tcp:$server[seal,bigendian] $OPTIONS \
+		ncacn_ip_tcp:${server}[seal,bigendian] $OPTIONS \
 		RPC-DRSUAPI || on_error "$name"
 }
 
@@ -82,7 +82,7 @@ ncacn_ip_tcp_tests()
 		for t in $tests; do
 			name="$t on $transport with $bindoptions"
 			bin/smbtorture $TORTURE_OPTIONS \
-				$transport:$server[$bindoptions] \
+				$transport:${server}[$bindoptions] \
 				$OPTIONS $t || on_error "$name"
 		done
 	done
@@ -98,7 +98,7 @@ ncacn_np_tests()
 		for t in $tests; do
 			name="$t on $transport with $bindoptions"
 			bin/smbtorture $TORTURE_OPTIONS \
-				$transport:$server[$bindoptions] \
+				$transport:${server}[$bindoptions] \
 				$OPTIONS $t || on_error "$name"
 		done
 	done