From: Theodore Ts'o Date: Mon, 17 Feb 2014 00:29:32 +0000 (-0500) Subject: ext4: don't leave i_crtime.tv_sec uninitialized X-Git-Tag: v3.4.83~95 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6c3515f0ec08a1aa21007f3b261d2c3445adaae7;p=thirdparty%2Fkernel%2Fstable.git ext4: don't leave i_crtime.tv_sec uninitialized commit 19ea80603715d473600cd993b9987bc97d042e02 upstream. If the i_crtime field is not present in the inode, don't leave the field uninitialized. Fixes: ef7f38359 ("ext4: Add nanosecond timestamps") Reported-by: Vegard Nossum Tested-by: Vegard Nossum Signed-off-by: "Theodore Ts'o" Signed-off-by: Greg Kroah-Hartman --- diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index d918b55f009c5..29224866f7431 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h @@ -751,6 +751,8 @@ do { \ if (EXT4_FITS_IN_INODE(raw_inode, einode, xtime)) \ (einode)->xtime.tv_sec = \ (signed)le32_to_cpu((raw_inode)->xtime); \ + else \ + (einode)->xtime.tv_sec = 0; \ if (EXT4_FITS_IN_INODE(raw_inode, einode, xtime ## _extra)) \ ext4_decode_extra_time(&(einode)->xtime, \ raw_inode->xtime ## _extra); \