From: mpage Date: Thu, 6 Mar 2025 20:11:50 +0000 (-0800) Subject: gh-118331: Fix `test_list.ListTest.test_no_memory` under trace refs build (#130921) X-Git-Tag: v3.14.0a6~129 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6c6600f6831aec15b2acbd7a9bb9c275bd5f4a32;p=thirdparty%2FPython%2Fcpython.git gh-118331: Fix `test_list.ListTest.test_no_memory` under trace refs build (#130921) Fix `test_list.ListTest.test_no_memory` under trace refs build Memory allocation ends up failing in _PyRefchainTrace(), which produces different output. Assert that we don't segfault, which is the thing we want to test and is less brittle than checking output. --- diff --git a/Lib/test/test_list.py b/Lib/test/test_list.py index 2a34fd04f350..725e07f3ad02 100644 --- a/Lib/test/test_list.py +++ b/Lib/test/test_list.py @@ -1,3 +1,4 @@ +import signal import sys import textwrap from test import list_tests, support @@ -324,8 +325,12 @@ class ListTest(list_tests.CommonTest): _testcapi.set_nomemory(0) l = [None] """) - _, _, err = assert_python_failure("-c", code) - self.assertIn("MemoryError", err.decode("utf-8")) + rc, _, _ = assert_python_failure("-c", code) + if support.MS_WINDOWS: + # STATUS_ACCESS_VIOLATION + self.assertNotEqual(rc, 0xC0000005) + else: + self.assertNotEqual(rc, -int(signal.SIGSEGV)) if __name__ == "__main__": unittest.main()