From: NRK <nrk@disroot.org>
Date: Mon, 2 Oct 2023 19:26:48 +0000 (+0600)
Subject: udevadm: avoid side-effect in assert()
X-Git-Tag: v255-rc1~354
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6c7b1ea1bed384b8f64ea0d45666bbf455f16726;p=thirdparty%2Fsystemd.git

udevadm: avoid side-effect in assert()

this was found when trying to use __builtin_assume() with clang:
https://github.com/systemd/systemd/pull/29409#issuecomment-1743575402
---

diff --git a/src/udev/udevadm-lock.c b/src/udev/udevadm-lock.c
index aa99e5497f3..89d7d256d2c 100644
--- a/src/udev/udevadm-lock.c
+++ b/src/udev/udevadm-lock.c
@@ -245,8 +245,8 @@ static int lock_device(
                                 sigset_t ss;
                                 usec_t n;
 
-                                assert(sigemptyset(&ss) >= 0);
-                                assert(sigaddset(&ss, SIGCHLD) >= 0);
+                                assert_se(sigemptyset(&ss) >= 0);
+                                assert_se(sigaddset(&ss, SIGCHLD) >= 0);
 
                                 n = now(CLOCK_MONOTONIC);
                                 if (n >= deadline)