From: Michael Adam <obnox@samba.org>
Date: Tue, 4 Sep 2012 13:23:01 +0000 (+0200)
Subject: s3: in sys_popen(), untangle function call from result check
X-Git-Tag: samba-4.0.0rc1~243
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6c7df39feeaeebeca88562e575aa0c803559b0d7;p=thirdparty%2Fsamba.git

s3: in sys_popen(), untangle function call from result check
---

diff --git a/source3/lib/system.c b/source3/lib/system.c
index 94603305370..58f7b478ad4 100644
--- a/source3/lib/system.c
+++ b/source3/lib/system.c
@@ -1188,8 +1188,10 @@ int sys_popen(const char *command)
 	 * Extract the command and args into a NULL terminated array.
 	 */
 
-	if(!(argl = extract_args(NULL, command)))
+	argl = extract_args(NULL, command);
+	if (argl == NULL) {
 		goto err_exit;
+	}
 
 	entry->child_pid = fork();