From: Zhengchao Shao Date: Mon, 7 Nov 2022 01:21:59 +0000 (+0800) Subject: net: ethernet: mtk-star-emac: disable napi when connect and start PHY failed in mtk_s... X-Git-Tag: v6.0.9~120 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6d11201ae5c1301f72d690f03934906f01eacbd2;p=thirdparty%2Fkernel%2Fstable.git net: ethernet: mtk-star-emac: disable napi when connect and start PHY failed in mtk_star_enable() [ Upstream commit b0c09c7f08c2467b2089bdf4adb2fbbc2464f4a8 ] When failed to connect to and start PHY in mtk_star_enable() for opening device, napi isn't disabled. When open mtk star device next time, it will reports a invalid opcode issue. Fix it. Only be compiled, not be tested. Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver") Signed-off-by: Zhengchao Shao Reviewed-by: Leon Romanovsky Link: https://lore.kernel.org/r/20221107012159.211387-1-shaozhengchao@huawei.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c index 3f0e5e64de505..57f4373b30ba1 100644 --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c @@ -1026,6 +1026,8 @@ static int mtk_star_enable(struct net_device *ndev) return 0; err_free_irq: + napi_disable(&priv->rx_napi); + napi_disable(&priv->tx_napi); free_irq(ndev->irq, ndev); err_free_skbs: mtk_star_free_rx_skbs(priv);