From: Volker Lendecke <vl@samba.org>
Date: Wed, 9 May 2012 08:56:54 +0000 (+0200)
Subject: s3: Fix Coverity ID 242716 Uninitialized scalar variable
X-Git-Tag: samba-4.0.0alpha21~220
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6d5bbb9a4bd3d1fb045f4e0873196a9b1d93ae2a;p=thirdparty%2Fsamba.git

s3: Fix Coverity ID 242716 Uninitialized scalar variable

In an error path we are closing key_hnd without opening it
---

diff --git a/source3/rpc_client/cli_winreg_spoolss.c b/source3/rpc_client/cli_winreg_spoolss.c
index a0bbd91c7d0..4aa1f28cb96 100644
--- a/source3/rpc_client/cli_winreg_spoolss.c
+++ b/source3/rpc_client/cli_winreg_spoolss.c
@@ -2907,7 +2907,8 @@ WERROR winreg_printer_setform1(TALLOC_CTX *mem_ctx,
 			       struct spoolss_AddFormInfo1 *form)
 {
 	uint32_t access_mask = SEC_FLAG_MAXIMUM_ALLOWED;
-	struct policy_handle hive_hnd, key_hnd;
+	struct policy_handle hive_hnd;
+	struct policy_handle key_hnd = { 0, };
 	struct winreg_String wvalue = { 0, };
 	DATA_BLOB blob;
 	uint32_t num_builtin = ARRAY_SIZE(builtin_forms1);