From: Ralph Boehme <slow@samba.org>
Date: Mon, 13 Nov 2023 09:36:14 +0000 (+0100)
Subject: smbd: tweak POSIX check in smbd_do_qfilepathinfo()
X-Git-Tag: talloc-2.4.2~534
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6e300ef73147e6549748593ce168e9763cd567be;p=thirdparty%2Fsamba.git

smbd: tweak POSIX check in smbd_do_qfilepathinfo()

This check is only needed for SMB2, so check for that, and in the SMB2 codepath
we'll always have a valid fsp, so we can drop that check.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/smbd/smb2_trans2.c b/source3/smbd/smb2_trans2.c
index 5ed2d9ffcac..3d13d05673b 100644
--- a/source3/smbd/smb2_trans2.c
+++ b/source3/smbd/smb2_trans2.c
@@ -3000,8 +3000,9 @@ NTSTATUS smbd_do_qfilepathinfo(connection_struct *conn,
 			ok = true;
 		}
 
-		if ((fsp != NULL) &&
-		    (fsp->posix_flags & FSP_POSIX_FLAGS_OPEN)) {
+		if (conn->sconn->using_smb2 &&
+		    (fsp->posix_flags & FSP_POSIX_FLAGS_OPEN))
+		{
 			DBG_DEBUG("SMB2 posix open\n");
 			ok = true;
 		}