From: Jan Janssen <medhefgo@web.de>
Date: Fri, 24 Sep 2021 08:24:38 +0000 (+0200)
Subject: sd-boot: Invert if in disk_get_part_uuid()
X-Git-Tag: v250-rc1~527
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6e7bb7d3eed21a02536c2fc28ec6272d6d9f45b9;p=thirdparty%2Fsystemd.git

sd-boot: Invert if in disk_get_part_uuid()
---

diff --git a/src/boot/efi/disk.c b/src/boot/efi/disk.c
index 196dc52be58..6d3c8285a15 100644
--- a/src/boot/efi/disk.c
+++ b/src/boot/efi/disk.c
@@ -8,29 +8,29 @@
 
 EFI_STATUS disk_get_part_uuid(EFI_HANDLE *handle, CHAR16 uuid[static 37]) {
         EFI_DEVICE_PATH *device_path;
+        _cleanup_freepool_ EFI_DEVICE_PATH *paths = NULL;
 
         assert(handle);
 
         /* export the device path this image is started from */
         device_path = DevicePathFromHandle(handle);
-        if (device_path) {
-                _cleanup_freepool_ EFI_DEVICE_PATH *paths = NULL;
-
-                paths = UnpackDevicePath(device_path);
-                for (EFI_DEVICE_PATH *path = paths; !IsDevicePathEnd(path); path = NextDevicePathNode(path)) {
-                        HARDDRIVE_DEVICE_PATH *drive;
-
-                        if (DevicePathType(path) != MEDIA_DEVICE_PATH)
-                                continue;
-                        if (DevicePathSubType(path) != MEDIA_HARDDRIVE_DP)
-                                continue;
-                        drive = (HARDDRIVE_DEVICE_PATH *)path;
-                        if (drive->SignatureType != SIGNATURE_TYPE_GUID)
-                                continue;
-
-                        GuidToString(uuid, (EFI_GUID *)&drive->Signature);
-                        return EFI_SUCCESS;
-                }
+        if (!device_path)
+                return EFI_NOT_FOUND;
+
+        paths = UnpackDevicePath(device_path);
+        for (EFI_DEVICE_PATH *path = paths; !IsDevicePathEnd(path); path = NextDevicePathNode(path)) {
+                HARDDRIVE_DEVICE_PATH *drive;
+
+                if (DevicePathType(path) != MEDIA_DEVICE_PATH)
+                        continue;
+                if (DevicePathSubType(path) != MEDIA_HARDDRIVE_DP)
+                        continue;
+                drive = (HARDDRIVE_DEVICE_PATH *)path;
+                if (drive->SignatureType != SIGNATURE_TYPE_GUID)
+                        continue;
+
+                GuidToString(uuid, (EFI_GUID *)&drive->Signature);
+                return EFI_SUCCESS;
         }
 
         return EFI_NOT_FOUND;