From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 17 Oct 2018 16:28:43 +0000 (+0200)
Subject: core: validate socket path with path_is_valid()
X-Git-Tag: v240~527^2~3
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6e9c4f450e7c8ba954301ce9f563f667b980b63e;p=thirdparty%2Fsystemd.git

core: validate socket path with path_is_valid()
---

diff --git a/src/core/dbus-socket.c b/src/core/dbus-socket.c
index 913cc74918f..da60cf110ad 100644
--- a/src/core/dbus-socket.c
+++ b/src/core/dbus-socket.c
@@ -360,6 +360,9 @@ static int bus_socket_set_transient_property(
                                 return sd_bus_error_setf(error, SD_BUS_ERROR_INVALID_ARGS, "Unknown Socket type: %s", t);
 
                         if (p->type != SOCKET_SOCKET) {
+                                if (!path_is_valid(p->path))
+                                        return sd_bus_error_setf(error, SD_BUS_ERROR_INVALID_ARGS, "Invalid socket path: %s", t);
+
                                 p->path = strdup(a);
                                 path_simplify(p->path, false);