From: Andrew Goodbody Date: Tue, 30 Sep 2025 15:52:22 +0000 (+0100) Subject: usb: musb-new: Null check before dereference X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6ea91bf8055b18b24828c449e33572ca9a9832eb;p=thirdparty%2Fu-boot.git usb: musb-new: Null check before dereference A null check for the variable 'data' was introduced before dereferencing it for set_phy_power but other uses were not so protected. Add the null check for other dereferences of 'data'. This issue was found by Smatch. Signed-off-by: Andrew Goodbody --- diff --git a/drivers/usb/musb-new/am35x.c b/drivers/usb/musb-new/am35x.c index 42bc816e4f1..ca4d798642e 100644 --- a/drivers/usb/musb-new/am35x.c +++ b/drivers/usb/musb-new/am35x.c @@ -402,7 +402,7 @@ static int am35x_musb_init(struct musb *musb) #endif /* Reset the musb */ - if (data->reset) + if (data && data->reset) data->reset(data->dev); /* Reset the controller */ @@ -417,7 +417,7 @@ static int am35x_musb_init(struct musb *musb) musb->isr = am35x_musb_interrupt; /* clear level interrupt */ - if (data->clear_irq) + if (data && data->clear_irq) data->clear_irq(data->dev); return 0;