From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Fri, 29 Apr 2022 13:55:59 +0000 (+0200)
Subject: libsystemd-network: add assert about packet length
X-Git-Tag: v251-rc2~46^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6f1b4574b464020ca306f08bd0dac4ca90fe7617;p=thirdparty%2Fsystemd.git

libsystemd-network: add assert about packet length

We reject too-short packets in client_receive_message_raw(), so
the packets that dhcp_packet_verify_headers() gets are of sufficient size.
But let's add an assert to clarify this for the reader.

Closes #23223.
---

diff --git a/src/libsystemd-network/dhcp-packet.c b/src/libsystemd-network/dhcp-packet.c
index ce40ad5c323..1543d9addee 100644
--- a/src/libsystemd-network/dhcp-packet.c
+++ b/src/libsystemd-network/dhcp-packet.c
@@ -129,6 +129,7 @@ int dhcp_packet_verify_headers(DHCPPacket *packet, size_t len, bool checksum, ui
         size_t hdrlen;
 
         assert(packet);
+        assert(len >= sizeof(DHCPPacket));
 
         /* IP */