From: Volker Lendecke <vl@samba.org>
Date: Mon, 24 Jun 2024 14:52:51 +0000 (+0200)
Subject: smbd: Don't leave a pointer variable uninitialized
X-Git-Tag: tdb-1.4.11~265
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6f68812d228b72d802980890a46cb557dd8b0272;p=thirdparty%2Fsamba.git

smbd: Don't leave a pointer variable uninitialized

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/smbd/smb1_negprot.c b/source3/smbd/smb1_negprot.c
index 52608e8a7dd..23bb726bc46 100644
--- a/source3/smbd/smb1_negprot.c
+++ b/source3/smbd/smb1_negprot.c
@@ -519,10 +519,10 @@ void reply_negprot(struct smb_request *req)
 
 	while (smbreq_bufrem(req, p) > 0) {
 
-		char **tmp;
-
-		tmp = talloc_realloc(talloc_tos(), cliprotos, char *,
-					   num_cliprotos+1);
+		char **tmp = talloc_realloc(talloc_tos(),
+					    cliprotos,
+					    char *,
+					    num_cliprotos + 1);
 		if (tmp == NULL) {
 			DEBUG(0, ("talloc failed\n"));
 			TALLOC_FREE(cliprotos);