From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Thu, 27 Jun 2019 16:45:30 +0000 (-0700)
Subject: closes bpo-37420: Handle errors during iteration in os.sched_setaffinity. (GH-14414)
X-Git-Tag: v3.8.0b2~41
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6fbed5350c786ab88868925d67f59e19d0ab841c;p=thirdparty%2FPython%2Fcpython.git

closes bpo-37420: Handle errors during iteration in os.sched_setaffinity. (GH-14414)

(cherry picked from commit 45a30af109f69a81576b87ea775863ba12d55316)

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
---

diff --git a/Lib/test/test_posix.py b/Lib/test/test_posix.py
index afa1398d4edc..9bdd2848afc8 100644
--- a/Lib/test/test_posix.py
+++ b/Lib/test/test_posix.py
@@ -1368,6 +1368,7 @@ class PosixTester(unittest.TestCase):
         self.assertEqual(posix.sched_getaffinity(0), mask)
         self.assertRaises(OSError, posix.sched_setaffinity, 0, [])
         self.assertRaises(ValueError, posix.sched_setaffinity, 0, [-10])
+        self.assertRaises(ValueError, posix.sched_setaffinity, 0, map(int, "0X"))
         self.assertRaises(OverflowError, posix.sched_setaffinity, 0, [1<<128])
         self.assertRaises(OSError, posix.sched_setaffinity, -1, mask)
 
diff --git a/Misc/NEWS.d/next/Library/2019-06-26-22-25-05.bpo-37420.CxFJ09.rst b/Misc/NEWS.d/next/Library/2019-06-26-22-25-05.bpo-37420.CxFJ09.rst
new file mode 100644
index 000000000000..dea1a2925014
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2019-06-26-22-25-05.bpo-37420.CxFJ09.rst
@@ -0,0 +1,2 @@
+:func:`os.sched_setaffinity` now correctly handles errors that arise during iteration over its ``mask`` argument.
+Patch by Brandt Bucher.
\ No newline at end of file
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
index 70b15360a2bb..4301e876c7ce 100644
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -6416,6 +6416,9 @@ os_sched_setaffinity_impl(PyObject *module, pid_t pid, PyObject *mask)
         }
         CPU_SET_S(cpu, setsize, cpu_set);
     }
+    if (PyErr_Occurred()) {
+        goto error;
+    }
     Py_CLEAR(iterator);
 
     if (sched_setaffinity(pid, setsize, cpu_set)) {