From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 11 Oct 2023 09:26:25 +0000 (+0200)
Subject: killall: suppress debug log if some cgroup doesn't have survive_final_kill_signal... 
X-Git-Tag: v255-rc1~274^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6fd38dc83ad5ae99355280ab81925d52fdfec038;p=thirdparty%2Fsystemd.git

killall: suppress debug log if some cgroup doesn't have survive_final_kill_signal xattr set

This is the default case, hence really no reason to be noisy about that.
---

diff --git a/src/shared/killall.c b/src/shared/killall.c
index 1011cd83d3f..ef715dbdfe3 100644
--- a/src/shared/killall.c
+++ b/src/shared/killall.c
@@ -60,7 +60,7 @@ static bool is_survivor_cgroup(pid_t pid) {
         /* user xattr support was added to kernel v5.7, try with the trusted namespace as a fallback */
         if (ERRNO_IS_NEG_XATTR_ABSENT(r))
                 r = cg_get_xattr_bool(cgroup_path, "trusted.survive_final_kill_signal");
-        if (r < 0)
+        if (r < 0 && !ERRNO_IS_NEG_XATTR_ABSENT(r))
                 log_debug_errno(r,
                                 "Failed to get survive_final_kill_signal xattr of %s, ignoring: %m",
                                 cgroup_path);