From: Timo Sirainen <tss@iki.fi>
Date: Thu, 28 Aug 2008 06:33:37 +0000 (+0300)
Subject: mail_index_lookup_seq*() could have returned wrong sequences with transaction views.
X-Git-Tag: 1.2.alpha1~46
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=705b3c6a8960e53442e503031a26492ff7253577;p=thirdparty%2Fdovecot%2Fcore.git

mail_index_lookup_seq*() could have returned wrong sequences with transaction views.
This caused assert-crashes in recent flag handling for mbox and maildir.

--HG--
branch : HEAD
---

diff --git a/src/lib-index/mail-index-transaction-view.c b/src/lib-index/mail-index-transaction-view.c
index f40b6912c9..2286808c43 100644
--- a/src/lib-index/mail-index-transaction-view.c
+++ b/src/lib-index/mail-index-transaction-view.c
@@ -127,9 +127,9 @@ static void tview_lookup_seq_range(struct mail_index_view *view,
 	if (*first_seq_r == 0) {
 		seq = tview->t->first_new_seq;
 		for (; seq <= tview->t->last_new_seq; seq++) {
+			rec = mail_index_transaction_lookup(tview->t, seq);
 			if (first_uid <= rec->uid)
 				break;
-			rec = mail_index_transaction_lookup(tview->t, seq);
 		}
 		if (seq > tview->t->last_new_seq) {
 			/* no messages in range */