From: Jim Meyering <jim@meyering.net>
Date: Sun, 22 Aug 1999 10:53:13 +0000 (+0000)
Subject: (run_shell): Declare with noreturn attribute.
X-Git-Tag: FILEUTILS-4_0j-trial~306
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=705cf20084614f16e11b162477f66bcae8450ef8;p=thirdparty%2Fcoreutils.git

(run_shell): Declare with noreturn attribute.
Use an explicit exit(1) rather than doing that through error.
---

diff --git a/src/su.c b/src/su.c
index 0f5efd22d8..1a871f8503 100644
--- a/src/su.c
+++ b/src/su.c
@@ -154,6 +154,8 @@ char *xstrdup ();
 
 extern char **environ;
 
+static void run_shell (const char *, const char *, char **) ATTRIBUTE_NORETURN;
+
 /* The name this program was run with.  */
 char *program_name;
 
@@ -398,7 +400,8 @@ run_shell (const char *shell, const char *command, char **additional_args)
       args[argno++] = *additional_args;
   args[argno] = NULL;
   execv (shell, (char **) args);
-  error (1, errno, _("cannot run %s"), shell);
+  error (0, errno, _("cannot run %s"), shell);
+  exit (1);
 }
 
 /* Return 1 if SHELL is a restricted shell (one not returned by