From: Eric Snow Date: Mon, 7 Aug 2023 23:10:57 +0000 (-0600) Subject: gh-107630: Fix Remaining Subinterpreters Crashes on Py_TRACE_REFS Builds (gh-107750) X-Git-Tag: v3.13.0a1~1039 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=707018cc75558d6695e9e199a3ed0c8a4ff7cbcc;p=thirdparty%2FPython%2Fcpython.git gh-107630: Fix Remaining Subinterpreters Crashes on Py_TRACE_REFS Builds (gh-107750) This is a follow-up to gh-107567 and gh-107733. We skip test_basic_multiple_interpreters_deleted_no_reset on tracerefs builds. The test breaks interpreter isolation a little, which doesn't work well with Py_TRACE_REFS builds, so I feel fine about skipping the test. --- diff --git a/Lib/test/test_import/__init__.py b/Lib/test/test_import/__init__.py index 163ed824ff1f..051711bfd1fe 100644 --- a/Lib/test/test_import/__init__.py +++ b/Lib/test/test_import/__init__.py @@ -2555,6 +2555,12 @@ class SinglephaseInitTests(unittest.TestCase): def test_basic_multiple_interpreters_deleted_no_reset(self): # without resetting; already loaded in a deleted interpreter + if hasattr(sys, 'getobjects'): + # It's a Py_TRACE_REFS build. + # This test breaks interpreter isolation a little, + # which causes problems on Py_TRACE_REF builds. + raise unittest.SkipTest('crashes on Py_TRACE_REFS builds') + # At this point: # * alive in 0 interpreters # * module def may or may not be loaded already